Skip to content

Conversation

@rwblair
Copy link
Member

@rwblair rwblair commented Sep 16, 2025

This implementation uses toLowerCase, the other option would be localeCompare. Folk wisdom online being localeCompare is slower, but works better for more languages.

fixes #49

@rwblair rwblair marked this pull request as ready for review September 16, 2025 20:50
Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a small suggestion, which you should feel free to take or leave.

@rwblair rwblair merged commit c145f3e into main Sep 25, 2025
15 of 18 checks passed
@codecov
Copy link

codecov bot commented Sep 25, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add check for case collision intollerance

3 participants